31759 - update verify flow to use migration filter#3971
Open
ketaki-deodhar wants to merge 2 commits intobcgov:mainfrom
Open
31759 - update verify flow to use migration filter#3971ketaki-deodhar wants to merge 2 commits intobcgov:mainfrom
ketaki-deodhar wants to merge 2 commits intobcgov:mainfrom
Conversation
argush3
reviewed
Jan 14, 2026
Comment on lines
+165
to
+173
| for cnt in range(batches): | ||
| offset = cnt * batch_size | ||
| print(f'🚀 Running batch {cnt + 1}...') | ||
| batch_results = verify( | ||
| colin_engine, lear_engine, mig_corp_candidates, batch_size, offset | ||
| ) | ||
| results.extend(batch_results) | ||
|
|
||
| print(f'🌟 Verification complete. Processed {batches} batches.') |
Collaborator
There was a problem hiding this comment.
can we keep using futures like we did in the previous code. that way we leverage prefect's parallelization functionality.
looking into this more...will have more for you in a bit
Collaborator
There was a problem hiding this comment.
try something like this:
# Process batches concurrently (Prefect futures via .submit())
futures = []
# 1) Submit all batch tasks (non-blocking)
for cnt in range(batches):
offset = cnt * batch_size
print(f'🚀 Submitting batch {cnt + 1}/{batches}...')
futures.append(
verify.submit(
colin_engine,
lear_engine,
mig_corp_candidates,
batch_size,
offset,
)
)
# 2) Resolve futures (blocking) and collect results
for f in futures:
batch_results = f.result()
results.extend(batch_results)
print(f'🌟 Verification complete. Processed {batches} batches.')
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#31759
Description of changes:
where_clauseUSE_MIGRATION_FILTER,MIG_GROUP_IDSandMIG_BATCH_IDSconfig valuesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).